✨ Support cross zone load balancing option #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ncdc
reviewed
Dec 20, 2019
|
@vincepri you still looking to get this in? |
k8s-ci-robot
added
the
needs-rebase
|
Sure, I can rebase in a bit |
vincepri
force-pushed
the
support-cross-zone
branch
from
19419e2
to
0b4e087
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@ncdc done! |
vincepri
force-pushed
the
support-cross-zone
branch
from
0b4e087
to
9c34b7b
Compare
ncdc
reviewed
Feb 3, 2020
api/v1alpha3/awscluster_types.go
Outdated
| @@ -80,6 +80,15 @@ type AWSLoadBalancerSpec struct { | |||
| // Scheme sets the scheme of the load balancer (defaults to Internet-facing) | |||
| // +optional | |||
| Scheme *ClassicELBScheme `json:"scheme,omitempty"` | |||
|
|
|||
| // CrossZoneLoadBalancing enables the classic load balancer load balancing. | |||
There was a problem hiding this comment.
Did you mean to say that it enables classic, or cross-zone?
|
Also add a unit test for round trip conversions? |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
support-cross-zone
branch
from
9c34b7b
to
b92a246
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1416