Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃弮 Update Machine FailureDomain field #1507

Merged
merged 1 commit into from
Jan 30, 2020
Merged

馃弮 Update Machine FailureDomain field #1507

merged 1 commit into from
Jan 30, 2020

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jan 30, 2020

Signed-off-by: Chuck Ha chuckh@vmware.com

Make the field name consistent with the json tag name and other documentation.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

related to kubernetes-sigs/cluster-api#2185

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Jan 30, 2020

actually... i'm just realizing this is defined as FailureDomain on the Machine. I want this to be consistent with Machine so I'm going to go the other direction with this.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2020
detiber
detiber reviewed Jan 30, 2020
View reviewed changes
api/v1alpha3/awsmachine_types.go

// AvailabilityZone is references the AWS availability zone to use for this instance.
// If multiple subnets are matched for the availability zone, the first one return is picked.
//
// DEPRECATED: Switch to FailureDomainID.
// DEPRECATED: Switch to FailureDomain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this PR, but since we are deprecating this field, should we be handling some type of automatic migration to the FailureDomain field as part of the conversion webhook? It looks like we are doing the reverse (populating the AvailabilityZone in v1alpha2 if FailureDomain is set in v1alpha3).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can, we might want to remove the field altogether though, this is only marked as a deprecation and we have a fallback in place that looks at the AvailabilityZone field if FailureDomain is nil.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with removing the field altogether as well :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file an issue so we don't forget as this is out of scope for the original intent of this PR

@chuckha
Update Machine FailureDomain field
2e24088 
Signed-off-by: Chuck Ha <chuckh@vmware.com>
@chuckha
Copy link
Contributor Author

chuckha commented Jan 30, 2020

/hold cancel

As stated above, held because I wanted to swap directions the PR was going. That is done.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@detiber
Copy link
Member

detiber commented Jan 30, 2020

/lgtm
/check-cla

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 926c6b5 into kubernetes-sigs:master Jan 30, 2020
@chuckha chuckha mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@vincepri vincepri vincepri left review comments

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chuckha @k8s-ci-robot @detiber @vincepri