Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [0.4] Support use of AWS Secrets Manager for userdata privacy #1517

Conversation

randomvariable
Copy link
Member

@randomvariable randomvariable commented Feb 4, 2020

Cherry pick of #1490 on release-0.4.

#1490: Support use of AWS Secrets Manager for userdata privacy

Also ported over the machine controller tests for extra safety.

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2020
@randomvariable randomvariable changed the title Automated cherry pick of #1490: Support use of AWS Secrets Manager for userdata privacy [wip] Automated cherry pick of #1490: Support use of AWS Secrets Manager for userdata privacy Feb 4, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2020
@randomvariable
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020
@randomvariable randomvariable force-pushed the automated-cherry-pick-of-#1490-upstream-release-0.4 branch 2 times, most recently from 85f7742 to 80c9353 Compare February 5, 2020 18:03
@randomvariable
Copy link
Member Author

/retest

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable randomvariable force-pushed the automated-cherry-pick-of-#1490-upstream-release-0.4 branch from 80c9353 to cef7e20 Compare February 5, 2020 18:31
@randomvariable randomvariable changed the title [wip] Automated cherry pick of #1490: Support use of AWS Secrets Manager for userdata privacy ✨ Automated cherry pick of #1490: Support use of AWS Secrets Manager for userdata privacy Feb 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2020
@randomvariable randomvariable changed the title ✨ Automated cherry pick of #1490: Support use of AWS Secrets Manager for userdata privacy ✨Support use of AWS Secrets Manager for userdata privacy Feb 5, 2020
@randomvariable randomvariable changed the title ✨Support use of AWS Secrets Manager for userdata privacy ✨ Support use of AWS Secrets Manager for userdata privacy Feb 5, 2020
@randomvariable
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@randomvariable
Copy link
Member Author

remove hold if e2e passes

@@ -0,0 +1,30 @@
# Userdata Privacy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole doc needs updating for 0.4 / v1alpha2.

@ncdc ncdc added this to the v0.4.x milestone Feb 5, 2020
Copy link
Contributor

@ncdc ncdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit f076fd5 into kubernetes-sigs:release-0.4 Feb 5, 2020
@ncdc ncdc changed the title ✨ Support use of AWS Secrets Manager for userdata privacy ✨ [0.4] Support use of AWS Secrets Manager for userdata privacy Feb 5, 2020
@randomvariable randomvariable deleted the automated-cherry-pick-of-#1490-upstream-release-0.4 branch February 6, 2020 08:43
richardchen-db pushed a commit to databricks/cluster-api-provider-aws-1 that referenced this pull request Jan 14, 2023
…-cherry-pick-of-#1490-upstream-release-0.4

✨ Support use of AWS Secrets Manager for userdata privacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants