New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [0.4] Support use of AWS Secrets Manager for userdata privacy #1517
✨ [0.4] Support use of AWS Secrets Manager for userdata privacy #1517
Conversation
/hold |
85f7742
to
80c9353
Compare
/retest |
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
80c9353
to
cef7e20
Compare
/test pull-cluster-api-provider-aws-e2e |
remove hold if e2e passes |
@@ -0,0 +1,30 @@ | |||
# Userdata Privacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whole doc needs updating for 0.4 / v1alpha2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-cherry-pick-of-#1490-upstream-release-0.4 ✨ Support use of AWS Secrets Manager for userdata privacy
Cherry pick of #1490 on release-0.4.
#1490: Support use of AWS Secrets Manager for userdata privacy
Also ported over the machine controller tests for extra safety.
For details on the cherry pick process, see the cherry pick requests page.