-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 secrets-manager: Fix error handling #1606
🐛 secrets-manager: Fix error handling #1606
Conversation
/hold |
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
a963644
to
0913458
Compare
/unhold |
LGTM but I'm going to do a manual test real quick. |
Works! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #1563 on master.
#1563: secrets-manager: Fix error handling
For details on the cherry pick process, see the cherry pick requests page.