-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bring AWS SDK in-line with Kubernetes master and add new regions #1612
Conversation
Hi @voor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test @voor Are there any additional changes needed for the region support, or is bumping the aws sdk enough? |
/retest |
… but for now just revert this.
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, voor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Adds support for additional AWS region endpoints (AWS ISO regions) allowing for support in those areas without explicitly overriding the AWS endpoint URLs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Based on discovery in slack thread https://kubernetes.slack.com/archives/CD6U2V71N/p1583175642128100?thread_ts=1583161863.102600&cid=CD6U2V71N