Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Loosen the filter used for image lookups #1653

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

detiber
Copy link
Member

@detiber detiber commented Mar 19, 2020

What this PR does / why we need it:

Currently image lookups are pretty strict about format, this loosens the image lookup filter while still retaining backward compatiblity for existing images produced.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@detiber
Copy link
Member Author

detiber commented Mar 19, 2020

/test pull-cluster-api-provider-aws-e2e

@detiber
Copy link
Member Author

detiber commented Mar 19, 2020

/assign @dims
/assign @rudoi

@detiber
Copy link
Member Author

detiber commented Mar 20, 2020

e2e test failure was a flake in 1 out of 13 tests

@detiber
Copy link
Member Author

detiber commented Mar 20, 2020

/assign @ncdc

pkg/cloud/services/ec2/ami.go Outdated Show resolved Hide resolved
@detiber
Copy link
Member Author

detiber commented Mar 20, 2020

/test pull-cluster-api-provider-aws-e2e

want to test just long enough to verify that the lookups still work

@ncdc
Copy link
Contributor

ncdc commented Mar 20, 2020

/hold
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 20, 2020
@detiber
Copy link
Member Author

detiber commented Mar 20, 2020

At least one of the e2e tests has successfully passed, which means it successfully did the lookup for the existing image :)
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 07ec7d9 into kubernetes-sigs:master Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

@detiber: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-aws-e2e 5170c58 link /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants