-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Loosen the filter used for image lookups #1653
✨ Loosen the filter used for image lookups #1653
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-aws-e2e |
e2e test failure was a flake in 1 out of 13 tests |
/assign @ncdc |
ad968ae
to
5170c58
Compare
/test pull-cluster-api-provider-aws-e2e want to test just long enough to verify that the lookups still work |
/hold |
At least one of the e2e tests has successfully passed, which means it successfully did the lookup for the existing image :) |
@detiber: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Currently image lookups are pretty strict about format, this loosens the image lookup filter while still retaining backward compatiblity for existing images produced.