🐛 clusterawsadm: ensure role policies work #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
randomvariable
force-pushed
the
clusterawsadmv2fix
branch
2 times, most recently
from
f19cde6
to
eee62c7
Compare
k8s-ci-robot
added
size/XXL
|
tests added |
k8s-ci-robot
removed
the
do-not-merge/hold
randomvariable
force-pushed
the
clusterawsadmv2fix
branch
from
eee62c7
to
cdfc0c7
Compare
|
urgh typos |
k8s-ci-robot
added
the
do-not-merge/hold
randomvariable
force-pushed
the
clusterawsadmv2fix
branch
from
cdfc0c7
to
e1f5867
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
detiber
reviewed
Jun 30, 2020
Ensure role policies actually work Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
clusterawsadmv2fix
branch
from
89f9dff
to
b68c341
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Attempting to add extra statements for a real use case led to the CloudFormation template failing because it was missing the policy name. I had also accidentally appended these statements to the managed policy, which is not the documented intent.
This also adds an "AllowedEC2InstanceProfiles" field to be set for the controller to override which EC2 IAM roles can be used by Cluster API.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Advice on testing strategies. Should I create a test directory with "correct" CloudFormation YAML's to compare the generator to?