✨ bastion: Make instance type selectable, with new defaults #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
randomvariable
changed the title
k8s-ci-robot
added
the
size/M
randomvariable
force-pushed
the
bastion-instance-type
branch
2 times, most recently
from
f73d657
to
e746d77
Compare
t2 instance type is starting to be removed from Amazon DCs, so update the default to the most universally available burstable micro instance, with an exception for us-east-1. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
bastion-instance-type
branch
from
e746d77
to
daf30e9
Compare
randomvariable
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-provider-aws-e2e-new |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
randomvariable
changed the title
vincepri
approved these changes
Aug 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
e2e passed. /unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naadir Jeewa jeewan@vmware.com
What this PR does / why we need it:
T2 instance type is starting to be removed from Amazon DCs, so update
the default to the most universally available burstable micro instance,
with an exception for us-east-1.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1830