Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GINKGO_SKIP conditions from Makefile to enable the e2e tests for CAPI #2946

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Remove GINKGO_SKIP conditions from Makefile to enable the e2e tests for CAPI #2946

merged 1 commit into from
Nov 15, 2021

Conversation

Ankitasw
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR updates the Makefile to remove the condition checks for GINKGO_SKIP for e2e tests such that CAPI tests are not skipped in testgrid.
It also fixes the unzip issue in mac OS while running e2e tests locally. Related to #2674

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

None

@k8s-ci-robot k8s-ci-robot added this to the v0.7.x milestone Nov 12, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 12, 2021
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2021
@randomvariable
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@randomvariable: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-release-0-7
  • /test pull-cluster-api-provider-aws-test-release-0-7
  • /test pull-cluster-api-provider-aws-verify-release-0-7

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-e2e-conformance-release-0-7
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-0-7
  • /test pull-cluster-api-provider-aws-e2e-eks-release-0-7
  • /test pull-cluster-api-provider-aws-e2e-release-0-7

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-release-0-7
  • pull-cluster-api-provider-aws-test-release-0-7
  • pull-cluster-api-provider-aws-verify-release-0-7

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randomvariable
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-release-0-7
/test pull-cluster-api-provider-aws-e2e-eks-release-0-7

@sedefsavas
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5aabdb1 into kubernetes-sigs:release-0.7 Nov 15, 2021
@Ankitasw Ankitasw deleted the release-0.7-fix branch November 15, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ankitasw @k8s-ci-robot @randomvariable @sedefsavas