Make logging for creating/deleting AWS resources consistent

[pydctw]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Make logging for creating/deleting AWS resources consistent. See #3143 for a detailed description.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3143

Special notes for your reviewer:
Added missing logs, formatted some logs and moved unimportant logs to level 2.

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Make logging for AWS resources creation/deletion consistent

[pydctw]

/test?

[k8s-ci-robot]

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@pydctw: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-aws-build
• /test pull-cluster-api-provider-aws-test
• /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-aws-e2e
• /test pull-cluster-api-provider-aws-e2e-blocking
• /test pull-cluster-api-provider-aws-e2e-conformance
• /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-aws-build
• pull-cluster-api-provider-aws-test
• pull-cluster-api-provider-aws-verify

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pydctw]

/test pull-cluster-api-provider-aws-e2e

[pydctw]

See manager.log for an updated output log.

[sedefsavas]

I think there is a systematic way you have in mind in this PR: logging as info() only at the end of a method and logging v2.info() elsewhere.
Unless we document this logic and agree on what to be consistent about during reviews, we will not have consistency.

Do you want to track this or maybe add documentation as part of this PR?

[Ankitasw]

This is really good observation, as I have recently got feedback that the logs are inconsistent. As @sedefsavas mentioned, I also think we should have documentation in place so that if we add new services/behavior, then this documentation might help follow consistency.
Also, do we have any guidelines on what to put for v(2) logs and what to put for other levels like ,v(4),v(6) etc?

[pydctw]

I think there is a systematic way you have in mind in this PR: logging as info() only at the end of a method and logging v2.info() elsewhere.

I actually didn't have any systematic way in mind 🙂 What I did was

• Add a missing creation log at the same log level as the existing deletion log
• Add a missing creation/deletion or adjust the log level for resources with same level of importance (subnet, sg, and etc)
• Thought Deleted association between route table and subnet and Detached internet gateway from VPC are not that important for users so moved the log level to V(2).

But 100% agree that it will be great to have a guidance on what log level to use across the repo. Will open an issue for discussion. Thank you for the suggestion, @sedefsavas and @Ankitasw.

[pydctw]

Created an issue for consistent logging as a follow up: #3152

[sedefsavas]

I actually didn't have any systematic way in mind 🙂 What I did was

I looked too hard for seeing consistency then =)

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment