New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added documentation for usage of failure domains #3173
docs: added documentation for usage of failure domains #3173
Conversation
@Ankitasw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think we can combine this with control plane AZ support: Also, this needs to be added to SUMMARY_PREFIX.md to be added to the book index. You can check locally how changes look by running |
So do we want to cover single-AZ and multi AZ support in control plane and worker nodes in same doc, i.e, |
Not the same file but section would be better, otherwise will be too long. My above comment:
|
01b77c7
to
373ecc2
Compare
f26fe8d
to
6200cb4
Compare
@sedefsavas Arranged the sections, please have a look. |
@@ -0,0 +1,132 @@ | |||
# Failure domains in worker nodes | |||
|
|||
To ensure that the worker machines are spread across failure domains, we need to create N `MachineDeployment` for your N failure domains, scaling them independently. Resiliency to failures comes from having multiple `MachineDeployment`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to elaborate here how .failureDomain and .Subnet relate?
e.g
We have 2 sources for subnets:
- If subnet.id or subnet.filters are specified, we directly query AWS
- All other cases use the subnets provided in the cluster network spec without ever calling AWS
Relates to #2864
cc @codablock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been present in control-planes. Do we want to add similar explanation for worker nodes as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thanks @Ankitasw, I had missed that. My +1 to present it in a way that's clear that apply to both cp and worker nodes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure @enxebre I will summarize it for both cp and worker nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note here, so that we know it applies for worker nodes as well
6200cb4
to
61fdf9f
Compare
61fdf9f
to
92e7bcb
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds the documentation for usage of failure domains in CAPA for control plane and worker nodes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2924
Checklist:
Release note: