Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation for usage of failure domains #3173

Merged
merged 1 commit into from Feb 14, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Feb 8, 2022

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR adds the documentation for usage of failure domains in CAPA for control plane and worker nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2924

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added documentation for usage of failure domains in control planes and worker nodes

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2022
@sedefsavas
Copy link
Contributor

I think we can combine this with control plane AZ support:
https://cluster-api-aws.sigs.k8s.io/topics/multi-az-control-planes.html
Maybe under a single section Failure Domains, with 2 subsections workers and control-plane. WDYT?

Also, this needs to be added to SUMMARY_PREFIX.md to be added to the book index. You can check locally how changes look by running make serve-book.

@Ankitasw
Copy link
Member Author

Ankitasw commented Feb 9, 2022

I think we can combine this with control plane AZ support:
https://cluster-api-aws.sigs.k8s.io/topics/multi-az-control-planes.html
Maybe under a single section Failure Domains, with 2 subsections workers and control-plane. WDYT?

So do we want to cover single-AZ and multi AZ support in control plane and worker nodes in same doc, i.e, Failure Domains ?

@sedefsavas
Copy link
Contributor

Not the same file but section would be better, otherwise will be too long. My above comment:

Maybe under a single section Failure Domains, with 2 subsections workers and control-plane. WDYT?

@Ankitasw Ankitasw changed the title docs: added documentation for usage of failure domains [WIP] docs: added documentation for usage of failure domains Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@Ankitasw Ankitasw changed the title [WIP] docs: added documentation for usage of failure domains docs: added documentation for usage of failure domains Feb 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@Ankitasw Ankitasw force-pushed the failure-domain-doc branch 4 times, most recently from f26fe8d to 6200cb4 Compare February 9, 2022 13:00
@Ankitasw
Copy link
Member Author

Ankitasw commented Feb 9, 2022

Not the same file but section would be better, otherwise will be too long.

@sedefsavas Arranged the sections, please have a look.

@@ -0,0 +1,132 @@
# Failure domains in worker nodes

To ensure that the worker machines are spread across failure domains, we need to create N `MachineDeployment` for your N failure domains, scaling them independently. Resiliency to failures comes from having multiple `MachineDeployment`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to elaborate here how .failureDomain and .Subnet relate?
e.g
We have 2 sources for subnets:

  1. If subnet.id or subnet.filters are specified, we directly query AWS
  2. All other cases use the subnets provided in the cluster network spec without ever calling AWS

Relates to #2864
cc @codablock

Copy link
Member Author

@Ankitasw Ankitasw Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been present in control-planes. Do we want to add similar explanation for worker nodes as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks @Ankitasw, I had missed that. My +1 to present it in a way that's clear that apply to both cp and worker nodes as well.

Copy link
Member Author

@Ankitasw Ankitasw Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @enxebre I will summarize it for both cp and worker nodes.

Copy link
Member Author

@Ankitasw Ankitasw Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note here, so that we know it applies for worker nodes as well

@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3666c9f into kubernetes-sigs:main Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for use of failure domains in CAPA with single-AZ constraints
5 participants