Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added verify-shellcheck make target #3178

Merged
merged 1 commit into from Feb 9, 2022
Merged

Added verify-shellcheck make target #3178

merged 1 commit into from Feb 9, 2022

Conversation

zeborg
Copy link
Contributor

@zeborg zeborg commented Feb 9, 2022

Signed-off-by: Abhinav Sinha abhinav@nirmata.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Added verify-shellcheck make target and its dependencies hack/utils.sh, hack/verify-shellcheck.sh

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3175

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added `verify-shellcheck` make target

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

@zeborg: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @zeborg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@sedefsavas
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2022
sedefsavas
sedefsavas reviewed Feb 9, 2022
View reviewed changes
hack/verify-shellcheck.sh
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give credit to wherever we copy this from.
Similar to:
https://github.com/kubernetes-sigs/cluster-api/blob/d38a4b1c13b5f26ac407eab85b83597662f630bd/util/patch/patch.go#L214

https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/3ead4407ea7d48535a429d433d15093566f53df6/hack/verify-shellcheck.sh#L19

sedefsavas
sedefsavas reviewed Feb 9, 2022
View reviewed changes
hack/utils.sh Outdated
@@ -0,0 +1,34 @@
#!/usr/bin/env bash
# Copyright 2019 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2019 The Kubernetes Authors.
# Copyright 2022 The Kubernetes Authors.

hack/verify-shellcheck.sh Outdated
@@ -0,0 +1,72 @@
#!/usr/bin/env bash
# Copyright 2019 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2019 The Kubernetes Authors.
# Copyright 2022 The Kubernetes Authors.

@sedefsavas sedefsavas added this to the v1.4.0 milestone Feb 9, 2022
@abhinav-nirmata
Added verify-shellcheck make target
2e26ebd 
Signed-off-by: Abhinav Sinha <abhinav@nirmata.com>

Implemented suggested changes

Signed-off-by: Abhinav Sinha <abhinav@nirmata.com>
@zeborg
Copy link
Contributor Author

zeborg commented Feb 9, 2022

Hi @sedefsavas, thanks for the review! I've made the changes as you've suggested.

@sedefsavas
Copy link
Contributor

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7e181ed into kubernetes-sigs:main Feb 9, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.4.0, v1.x Feb 9, 2022
@pydctw pydctw mentioned this pull request Feb 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedefsavas sedefsavas sedefsavas left review comments

@dthorsen dthorsen Awaiting requested review from dthorsen

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add verify-shellcheck to Makefile target
4 participants
@zeborg @k8s-ci-robot @sedefsavas @abhinav-nirmata