Added verify-book-links make target

[zeborg]

Signed-off-by: Abhinav Sinha abhinav@nirmata.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

• Added verify-book-links make target
• Upgraded image maven:3-jdk-14 to maven:3-openjdk-17-slim in hack/tools/plantuml.Dockerfile for multi-arch (amd64 and arm64) support
• Updated docs/proposal/20200506-single-controller-multitenancy-flow.svg to the newly generated one

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3176

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Added `verify-book-links` make target

[k8s-ci-robot]

@zeborg: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @zeborg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sedefsavas]

/ok-to-test

[sedefsavas]

Suggested change

echo verification of book links initiated

[zeborg]

Hi @sedefsavas, looking at the failed logs it seems like in order for this test to succeed we also need to install Docker in the verify-book-links CI job. I'd like to know if I should implement this change as well. Thanks!

[zeborg]

Update:

Hi @sedefsavas, I tried to check if Docker was present in the CI environment, and it seems like it is already installed but the docker daemon is not running. I'm not sure about what the underlying OS is, and if the env privileges would allow us to start the docker daemon through shell. I might need your input here to understand how I should further proceed with this issue.
Thanks!

For context, here are the logs from the failed run:

499 make -C docs/book verify
500 make[1]: Entering directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/docs/book'
501 make -C ../ diagrams
502 make[2]: Entering directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/docs'
503 make -C ../hack/tools bin/plantuml-sentinal
504 make[3]: Entering directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/hack/tools'
505 docker build --build-arg PLANTUML_VERSION=1.2020.16  . -f plantuml.Dockerfile -t "plantuml-builder"
506 touch bin/plantuml-sentinal
507 failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: no such file or directory
508 make[3]: *** [Makefile:161: bin/plantuml-sentinal] Error 1
509 make[3]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/hack/tools'
510 make[2]: *** [../common.mk:50: ../hack/tools/bin/plantuml-sentinal] Error 2
511 make[2]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/docs'
512 make[1]: *** [Makefile:61: generate] Error 2
513 make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/docs/book'
514 make: *** [Makefile:620: verify-book-links] Error 2

[richardcase]

Our verify implementation in different to upstream capi (they just call mdbook build).

Was this working ok previously? Probably not.

Actually i think i can see the project....

[richardcase]

@sedefsavas @zeborg - as we want to run a container as part of the verify make target we need to run the prow job in privileged mode. This should do that:

kubernetes/test-infra#25240

[sedefsavas]

Our verify implementation in different to upstream capi (they just call mdbook build).

I think we can add that too. We only test uml creation as is.

[richardcase]

I just made a change to the prow job definition so that we execute the make target via runner.sh which setups DIND:

kubernetes/test-infra#25264

[richardcase]

/test pull-cluster-api-provider-aws-verify

[richardcase]

Doesn't look like Prow has the updated job definition yet.....lets try again in a bit.

[richardcase]

/test pull-cluster-api-provider-aws-verify

[richardcase]

Looking more promising this time:

 Docker in Docker enabled, initializing...
================================================================================
Starting Docker: docker.
Waiting for docker to be ready, sleeping for 1 seconds. 

Fingers crossed

[richardcase]

Yay it passed

[richardcase]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment