New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added go report badge #3210
Added go report badge #3210
Conversation
@shivi28: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, adding go reference badge is useful like CAPI has.
https://pkg.go.dev/sigs.k8s.io/cluster-api-provider-aws
README.md
Outdated
@@ -4,9 +4,15 @@ | |||
<img src="https://github.com/kubernetes/kubernetes/raw/master/logo/logo.png" width="100x"><a href="https://aws.amazon.com/opensource/"><img width="192x" src="https://d0.awsstatic.com/logos/powered-by-aws.png" alt="Powered by AWS Cloud Computing"></a> | |||
</p> | |||
<p align="center"> | |||
<!-- build passing badge --> | |||
<a href="https://prow.k8s.io/?job=post-cluster-api-provider-aws-push-images"> | |||
<img alt="Build Status" src="https://prow.k8s.io/badge.svg?jobs=post-cluster-api-provider-aws-push-images"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://prow.k8s.io/?job=post-cluster-api-provider-aws-push-image is not showing any jobs.
Also it is not the build job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today we are not seeing any build list for any provider on prow jobs. I checked in CAPI repository as well. CAPI's build list is also empty https://prow.k8s.io/?job=post-cluster-api-push-images
.
I will post my findings once I will get some more hints on why it's happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed build passing
badge as the core of our tests are in prow and we might get same build | no results
multiple times, so feels it's not good to show it on repo
Yes, Go reference we already have in CAPA's Readme.md |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
This PR adds
go report
badges in CAPA project.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3209
Special notes for your reviewer:
Now we can see following badges in CAPA repo.
Checklist:
Release note: