Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go report badge #3210

Merged
merged 1 commit into from Feb 15, 2022
Merged

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Feb 12, 2022

What type of PR is this?

What this PR does / why we need it:
This PR adds go report badges in CAPA project.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3209

Special notes for your reviewer:
Now we can see following badges in CAPA repo.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added go report badge in CAPA

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 12, 2022
@k8s-ci-robot
Copy link
Contributor

@shivi28: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2022
Copy link
Contributor

@sedefsavas sedefsavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, adding go reference badge is useful like CAPI has.
https://pkg.go.dev/sigs.k8s.io/cluster-api-provider-aws

README.md Outdated
@@ -4,9 +4,15 @@
<img src="https://github.com/kubernetes/kubernetes/raw/master/logo/logo.png" width="100x"><a href="https://aws.amazon.com/opensource/"><img width="192x" src="https://d0.awsstatic.com/logos/powered-by-aws.png" alt="Powered by AWS Cloud Computing"></a>
</p>
<p align="center">
<!-- build passing badge -->
<a href="https://prow.k8s.io/?job=post-cluster-api-provider-aws-push-images">
<img alt="Build Status" src="https://prow.k8s.io/badge.svg?jobs=post-cluster-api-provider-aws-push-images"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://prow.k8s.io/?job=post-cluster-api-provider-aws-push-image is not showing any jobs.
Also it is not the build job.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today we are not seeing any build list for any provider on prow jobs. I checked in CAPI repository as well. CAPI's build list is also empty https://prow.k8s.io/?job=post-cluster-api-push-images.

I will post my findings once I will get some more hints on why it's happening

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed build passing badge as the core of our tests are in prow and we might get same build | no results multiple times, so feels it's not good to show it on repo

@shivi28
Copy link
Contributor Author

shivi28 commented Feb 14, 2022

Also, adding go reference badge is useful like CAPI has. https://pkg.go.dev/sigs.k8s.io/cluster-api-provider-aws

Yes, Go reference we already have in CAPA's Readme.md

@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@shivi28 shivi28 changed the title Added build passing and go report badge Added go report badge Feb 15, 2022
@sedefsavas
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit a835c46 into kubernetes-sigs:main Feb 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Go report and build passing badges in CAPA project
3 participants