Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the release process to use GitHub Release Notes #3214

Conversation

meghanajangi
Copy link
Member

@meghanajangi meghanajangi commented Feb 14, 2022

Signed-off-by: Meghana Jangi mjangi@vmware.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
To change the release process to use GitHub Release Notes instead of the release-notes cli.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3170
Fixes #2835

Special notes for your reviewer:
I have made the changes mentioned in the issue description except the following:

  • Add any post generation header or footer text to generated markdown file.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Change the release process to use GitHub Release Notes

@k8s-ci-robot
Copy link
Contributor

@meghanajangi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority labels Feb 14, 2022
@k8s-ci-robot
Copy link
Contributor

@meghanajangi: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 14, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @meghanajangi!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @meghanajangi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2022
.github/release.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/release.yml Outdated Show resolved Hide resolved
.github/release.yml Outdated Show resolved Hide resolved
.github/release.yml Outdated Show resolved Hide resolved
.github/release.yml Outdated Show resolved Hide resolved
.github/release.yml Show resolved Hide resolved
@sedefsavas
Copy link
Contributor

Also, we could have a section for Dependencies.

There is no specific kind used for those but /area release is used.

@meghanajangi
Copy link
Member Author

Also, we could have a section for Dependencies.

There is no specific kind used for those but /area release is used.

Sure, I can add that.
Also had a few questions about some of the remaining labels:

  • Would kind/proposal be under Documentation section?
  • Should there be a separate section for kind/deprecation and kind/design?

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sedefsavas
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2022
@sedefsavas sedefsavas added this to the v1.4.0 milestone Feb 22, 2022
@sedefsavas sedefsavas removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 22, 2022
@meghanajangi meghanajangi force-pushed the use-github-release-notes-generation branch from c12216d to 0da71d2 Compare February 28, 2022 10:00
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2022
@meghanajangi meghanajangi force-pushed the use-github-release-notes-generation branch from c4ee2b4 to a6efb5c Compare March 8, 2022 04:57
@Ankitasw
Copy link
Member

Ankitasw commented Mar 9, 2022

/lgtm
@meghanajangi can you push a blank commit so that netlify error goes off

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
hack/releasechangelog.sh Outdated Show resolved Hide resolved
hack/releasechangelog.sh Show resolved Hide resolved
@richardcase
Copy link
Member

@meghanajangi - just a couple of small comments on this one.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@meghanajangi meghanajangi force-pushed the use-github-release-notes-generation branch from a6efb5c to 5ff4482 Compare March 16, 2022 11:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@meghanajangi meghanajangi force-pushed the use-github-release-notes-generation branch 2 times, most recently from 842b1da to 6b2bad7 Compare March 16, 2022 11:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@meghanajangi meghanajangi force-pushed the use-github-release-notes-generation branch from 6b2bad7 to d8ad80f Compare March 16, 2022 11:57
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022
Signed-off-by: Meghana Jangi <mjangi@vmware.com>
Co-authored-by: sedefsavas <58447606+sedefsavas@users.noreply.github.com>
@meghanajangi meghanajangi force-pushed the use-github-release-notes-generation branch from d8ad80f to 7ee7ca5 Compare March 23, 2022 11:12
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2022
@richardcase
Copy link
Member

@sedefsavas - i can't see anything else needed with this so from my side:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2022
@sedefsavas
Copy link
Contributor

We probably need to remove release-note plugin from Prow to remove release-note needed label:

  kubernetes-sigs/cluster-api-provider-aws:
    plugins:
    - golint
    - mergecommitblocker
    - milestone
    - milestonestatus
    - override
    - release-note
    - require-matching-label

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@sedefsavas
Copy link
Contributor

Created a PR for removing the release-note-needed label.
https://github.com/kubernetes/test-infra/pull/25762/files

@sedefsavas sedefsavas merged commit ba0b47f into kubernetes-sigs:main Mar 25, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.4.0, v1.x Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GitHub Release Note Generation Release note generation issue
5 participants