Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AwsClusterTemplate printcolumn and remove unnecessary RBAC files #3217

Merged
merged 2 commits into from Feb 18, 2022

Conversation

pydctw
Copy link
Contributor

@pydctw pydctw commented Feb 14, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  1. Added printcolumn, Age, to AWSClusterTemplate. This is in line with other templates like KubeadmControlplaneTemplate or DockerClusterTemplate in CAPI.
  2. Deleted unnecessary RBAC roles created for AWSClusterTemplate

Also, cleaned up a duplicate kubebuilder marker for AWSManagedControlPlane

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2022
@k8s-ci-robot
Copy link
Contributor

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Feb 14, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
Also, deleted unnecessary RBAC roles created for AWSClusterTemplate
This is in line with other templates like KubeadmControlplaneTemplate or DockerClusterTemplate in CAPI.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Feb 14, 2022

cc @ykakarap. Removing the RBAC files as part of this PR.

@pydctw
Copy link
Contributor Author

pydctw commented Feb 14, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@Ankitasw
Copy link
Member

Hey @pydctw , thanks for the PR.
Could you give some context for why this Age column is needed?

Added printcolumn, Age, to AWSClusterTemplate

@pydctw
Copy link
Contributor Author

pydctw commented Feb 15, 2022

Hey @pydctw , thanks for the PR. Could you give some context for why this Age column is needed?

Added printcolumn, Age, to AWSClusterTemplate

This is following the convention of newly added templates for ClusterClass in CAPI. Making them consistent.

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to dropping these RBAC files. We dont use them and can be dropped safely.

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 24e3ea2 into kubernetes-sigs:main Feb 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants