New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AwsClusterTemplate printcolumn and remove unnecessary RBAC files #3217
Update AwsClusterTemplate printcolumn and remove unnecessary RBAC files #3217
Conversation
@pydctw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Also, deleted unnecessary RBAC roles created for AWSClusterTemplate This is in line with other templates like KubeadmControlplaneTemplate or DockerClusterTemplate in CAPI.
6a83919
to
1d02d90
Compare
cc @ykakarap. Removing the RBAC files as part of this PR. |
/hold cancel |
Hey @pydctw , thanks for the PR.
|
This is following the convention of newly added templates for ClusterClass in CAPI. Making them consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to dropping these RBAC files. We dont use them and can be dropped safely.
config/crd/bases/infrastructure.cluster.x-k8s.io_awsclustertemplates.yaml
Show resolved
Hide resolved
config/crd/bases/infrastructure.cluster.x-k8s.io_awsclustertemplates.yaml
Show resolved
Hide resolved
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Age
, to AWSClusterTemplate. This is in line with other templates like KubeadmControlplaneTemplate or DockerClusterTemplate in CAPI.Also, cleaned up a duplicate kubebuilder marker for AWSManagedControlPlane
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: