New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClusterSecurityGroupsReadyCondition to managedcontrolplane's patchObject #3234
Add ClusterSecurityGroupsReadyCondition to managedcontrolplane's patchObject #3234
Conversation
@pydctw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e-eks |
CAPA log from pull-cluster-api-provider-aws-e2e-eks doesn't have I checked the past 5 runs from the periodic-eks-e2e-main and they all had this error consistently. Was this the root cause of #2180? Will run e2e test a few times to confirm that the error is gone. |
/test pull-cluster-api-provider-aws-e2e-eks |
/test pull-cluster-api-provider-aws-e2e-eks |
/lgtm |
/assign @richardcase |
@richardcase @sedefsavas I think this is pending for approval. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-aws-build |
What type of PR is this?
/kind bug
What this PR does / why we need it:
While reviewing #3157 and doing more investigation, I found that ClusterSecurityGroupsReadyCondition is not part of managedcontrolplane's patchObject function's owned conditions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2180
Special notes for your reviewer:
Checklist:
Release note: