Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterSecurityGroupsReadyCondition to managedcontrolplane's patchObject #3234

Merged
merged 1 commit into from Mar 1, 2022

Conversation

pydctw
Copy link
Contributor

@pydctw pydctw commented Feb 18, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
While reviewing #3157 and doing more investigation, I found that ClusterSecurityGroupsReadyCondition is not part of managedcontrolplane's patchObject function's owned conditions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2180

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Feb 18, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@pydctw
Copy link
Contributor Author

pydctw commented Feb 18, 2022

CAPA log from pull-cluster-api-provider-aws-e2e-eks doesn't have error patching conditions: The condition \"ClusterSecurityGroupsReady\" was modified by a different process anymore. This was also the case when I tested it locally.

I checked the past 5 runs from the periodic-eks-e2e-main and they all had this error consistently.

Was this the root cause of #2180? Will run e2e test a few times to confirm that the error is gone.

@pydctw
Copy link
Contributor Author

pydctw commented Feb 18, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@pydctw
Copy link
Contributor Author

pydctw commented Feb 18, 2022

Collecting CAPA log from eks e2e test runs - no error patching conditions observed

@pydctw
Copy link
Contributor Author

pydctw commented Feb 18, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Feb 22, 2022

/assign @richardcase
for approval

@Ankitasw
Copy link
Member

Ankitasw commented Mar 1, 2022

@richardcase @sedefsavas I think this is pending for approval.

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Mar 1, 2022

/test pull-cluster-api-provider-aws-build

@k8s-ci-robot k8s-ci-robot merged commit 2d5075c into kubernetes-sigs:main Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditions error on deleting AWSManagedControlPlane
4 participants