Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block ELB re-creation after the cluster has been provisioned #3240

Merged
merged 1 commit into from Mar 1, 2022
Merged

Block ELB re-creation after the cluster has been provisioned #3240

merged 1 commit into from Mar 1, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Feb 21, 2022 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Since ELB is created only when it's not found, this PR blocks the ELB creation in the scenario where if user deletes ELB post the cluster has been provisioned. The reason to do this is if ELB is created again after the cluster has been provisioned, then CAPA will create new ELB with new DNS endpoint which won't work.
As AWSClusterSpec.ControlPlaneEndpoint becomes immutable after cluster is provisioned, we are relying on the validity of this endpoint to know the status of provisioning of the cluster to check whether ELB has to be created or not. If this endpoint is valid and ELB is not found, then we inform the user that AWSCluster is in failed state and unrecoverable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2608

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Block ELB re-creation after cluster is provisioned.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 21, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2022
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas sedefsavas added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Feb 22, 2022
@sedefsavas sedefsavas added this to the v1.4.0 milestone Feb 22, 2022
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit db14d13 into kubernetes-sigs:main Mar 1, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.4.0, v1.x Mar 1, 2022
@Ankitasw Ankitasw deleted the block-recreate-elb branch March 1, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@richardcase richardcase Awaiting requested review from richardcase

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't attempt to recreate an ELB after the cluster has been provisioned
3 participants
@Ankitasw @k8s-ci-robot @sedefsavas