New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hack/tools/golangci-lint and fix lint errors #3241
Bump hack/tools/golangci-lint and fix lint errors #3241
Conversation
@Ankitasw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a074731
to
0b403b0
Compare
sections: | ||
- standard | ||
- default | ||
- prefix(sigs.k8s.io/cluster-api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has been added since the make lint
was giving following warning:
WARN [linters context] gci:
local-prefixes
is deprecated, usesections
andprefix(sigs.k8s.io/cluster-api)
instead.
Refer here for example usage of sections
.
This will block any of the cluster-api related imports from being imported before 3rd party/static libraries.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/area release
What this PR does / why we need it:
This PR bumps hack/tools/golangci-lint from 1.44.0 to 1.44.2.
It also removes the use of deprecated
local-prefixes
ofgci
ingolangci-lint.yml
and replaces it withsections
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3239
Checklist:
Release note: