Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for usage of externally managed clusters #3247

Merged
merged 1 commit into from Mar 9, 2022
Merged

Documentation for usage of externally managed clusters #3247

merged 1 commit into from Mar 9, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Feb 23, 2022 •
edited

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR adds the documentation for briefly explaining about externally managed clusters(not EKS-managed clusters) and how to use it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2412

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added documentation for usage of externally managed clusters.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2022
@Ankitasw Ankitasw force-pushed the externally-managed-clusters branch 2 times, most recently from a22b846 to b7fc776 Compare February 23, 2022 16:55
@sedefsavas
Copy link
Contributor

I think we don't need to have a new page for this, it can go under
https://cluster-api-aws.sigs.k8s.io/topics/consuming-existing-aws-infrastructure.html

A little reorg might be needed to combine these.

@Ankitasw
Copy link
Member Author

Ankitasw commented Feb 23, 2022 •
edited

I think we don't need to have a new page for this, it can go under
https://cluster-api-aws.sigs.k8s.io/topics/consuming-existing-aws-infrastructure.html
A little reorg might be needed to combine these.

Sure, will take care of that

sedefsavas
sedefsavas reviewed Mar 8, 2022
View reviewed changes
docs/book/src/topics/externally-managed-aws-infrastructure.md Outdated

## Prerequisites
There are two possible ways to make use of externally managed AWS infrastructure:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to clarify what we mean here. We are not talking about EKS-managed (managed) clusters in the document. Because one might think EKS-managed clusters are also externally managed, their control-plane is managed by EKS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sedefsavas
Copy link
Contributor

/approve

/hold

until the above comment is resolved.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@Ankitasw Ankitasw force-pushed the externally-managed-clusters branch from 32664d5 to d7b7297 Compare March 8, 2022 08:21
@Ankitasw
Copy link
Member Author

Ankitasw commented Mar 8, 2022

/approve

/hold

until the above comment is resolved.

@sedefsavas Resolved now.

@Ankitasw Ankitasw requested a review from sedefsavas March 8, 2022 10:42
@sedefsavas sedefsavas removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@sedefsavas
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 40cf298 into kubernetes-sigs:main Mar 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Mar 9, 2022
@Ankitasw Ankitasw deleted the externally-managed-clusters branch March 10, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for externally managed clusters
3 participants
@Ankitasw @k8s-ci-robot @sedefsavas