Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added subnet IDs lookup by AWSMachinePool Spec Subnets.Filters #3255

Merged
merged 1 commit into from Mar 8, 2022
Merged

Added subnet IDs lookup by AWSMachinePool Spec Subnets.Filters #3255

merged 1 commit into from Mar 8, 2022

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Feb 25, 2022 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently we are doing lookup by subnet IDs only. But with this PR we enable

if subnet id is there, do a lookup using that
if filter is there, do a lookup using that
If both are given then it will throw a validation error as per comment on AWSResourceReference

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3254
Fixes #2609
Part of #2087

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added subnet IDs lookup by AWSMachinePool Spec Subnets.Filters in case IDs not provided

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 25, 2022
@k8s-ci-robot
Copy link
Contributor

@shivi28: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2022
@shivi28 shivi28 changed the title Use AWSMachinePool Spec Subnet.Filters to fetch subnet IDs Use AWSMachinePool Spec Subnets.Filters to fetch subnet IDs Feb 25, 2022
@shivi28 shivi28 mentioned this pull request Feb 25, 2022
Closed
4 tasks
@Ankitasw
Copy link
Member

Ankitasw commented Mar 1, 2022

/hold
in favor of #3254 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@sedefsavas sedefsavas mentioned this pull request Mar 2, 2022
Merged
4 tasks
@Ankitasw
Copy link
Member

Ankitasw commented Mar 2, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@shivi28 shivi28 changed the title Use AWSMachinePool Spec Subnets.Filters to fetch subnet IDs [WIP] Use AWSMachinePool Spec Subnets.Filters to fetch subnet IDs Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022
@shivi28 shivi28 mentioned this pull request Mar 2, 2022
Closed
@shivi28 shivi28 mentioned this pull request Mar 2, 2022
Closed
3 tasks
@shivi28 shivi28 changed the title [WIP] Use AWSMachinePool Spec Subnets.Filters to fetch subnet IDs [WIP] Added subnet IDs lookup by AWSMachinePool Spec Subnets.Filters Mar 2, 2022
@shivi28
Copy link
Contributor Author

shivi28 commented Mar 2, 2022

/pull-cluster-api-provider-aws-test

@shivi28
Copy link
Contributor Author

shivi28 commented Mar 2, 2022

/test ?

@k8s-ci-robot
Copy link
Contributor

@shivi28: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shivi28
Copy link
Contributor Author

shivi28 commented Mar 2, 2022

/test pull-cluster-api-provider-aws-test

@shivi28 shivi28 changed the title [WIP] Added subnet IDs lookup by AWSMachinePool Spec Subnets.Filters Added subnet IDs lookup by AWSMachinePool Spec Subnets.Filters Mar 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022
@shivi28
Copy link
Contributor Author

shivi28 commented Mar 2, 2022

/test pull-cluster-api-provider-aws-test

@shivi28 shivi28 force-pushed the subnet_filter branch 3 times, most recently from ddaa451 to a08f5f0 Compare March 3, 2022 14:59
@shivi28
Copy link
Contributor Author

shivi28 commented Mar 3, 2022

/test pull-cluster-api-provider-aws-apidiff-main

@shivi28
Copy link
Contributor Author

shivi28 commented Mar 8, 2022

/test pull-cluster-api-provider-aws-test

sedefsavas
sedefsavas reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@sedefsavas sedefsavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.
/approve

/assign @Ankitasw for lgtm as you have a related PR open.

exp/api/v1beta1/awsmachinepool_webhook.go Outdated Show resolved Hide resolved
exp/api/v1beta1/awsmachinepool_webhook.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@sedefsavas sedefsavas added this to the v1.4.0 milestone Mar 8, 2022
@shivi28
Use AWSMachinePool Spec subnet filters to fetch subnet IDs
10af88c 
Co-authored-by: calvix
Co-authored-by: Shivani Singhal <sishivani@vmware.com>
@k8s-ci-robot
Copy link
Contributor

@shivi28: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main 10af88c link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ankitasw
Copy link
Member

Ankitasw commented Mar 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 713e5d3 into kubernetes-sigs:main Mar 8, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.4.0, v1.x Mar 8, 2022
@Ankitasw
Copy link
Member

Ankitasw commented Mar 8, 2022

@shivi28 i forgot mentioning about the unit tests for webhook changes. Could you please make that change in separate PR ?
cc @sedefsavas

@Ankitasw Ankitasw mentioned this pull request Mar 9, 2022
Closed
@shivi28
Copy link
Contributor Author

shivi28 commented Mar 15, 2022

@shivi28 i forgot mentioning about the unit tests for webhook changes. Could you please make that change in separate PR ? cc @sedefsavas

Raised PR for requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedefsavas sedefsavas sedefsavas left review comments

@Ankitasw Ankitasw Ankitasw left review comments

@pydctw pydctw Awaiting requested review from pydctw

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@shivi28 @k8s-ci-robot @Ankitasw @sedefsavas