Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functioning Sec Groups E2E test and refactor AWS infrastructure functions #3261

Merged
merged 1 commit into from Mar 2, 2022
Merged

Functioning Sec Groups E2E test and refactor AWS infrastructure functions #3261

merged 1 commit into from Mar 2, 2022

Conversation

josh-ferrell
Copy link

Initial Sec Groups E2E test and refactor AWS infrastructure functions

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds an E2E test for validating CAPA with managed VPC, subnets and security groups

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Adds an E2E test for validating CAPA with managed VPC, subnets and security groups

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2022
@k8s-ci-robot
Copy link
Contributor

@josh-ferrell: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @josh-ferrell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2022
@josh-ferrell
Copy link
Author

This PR addresses one use case on #3249

@Ankitasw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2022
@pydctw
Copy link
Contributor

pydctw commented Feb 28, 2022

/test pull-cluster-api-provider-aws-e2e

@josh-ferrell
Copy link
Author

@pydctw let me see if I can determine why that Internet gateway detachment failed. I haven't see this locally.

@k8s-ci-robot
Copy link
Contributor

@josh-ferrell: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@josh-ferrell
Copy link
Author

/test pull-cluster-api-provider-aws-e2e

@josh-ferrell josh-ferrell changed the title Functioning Sec Groups E2E test and refactor AWS infrastructure functions WIP: Functioning Sec Groups E2E test and refactor AWS infrastructure functions Feb 28, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2022
@josh-ferrell
Copy link
Author

/test pull-cluster-api-provider-aws-e2e

@josh-ferrell josh-ferrell changed the title WIP: Functioning Sec Groups E2E test and refactor AWS infrastructure functions Functioning Sec Groups E2E test and refactor AWS infrastructure functions Feb 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2022
@josh-ferrell
Copy link
Author

@pydctw I've kicked off this test again. It's passed twice now but I'll wait to see how this goes as I'm not sure why the detach operation for the Internet gateway failed the first time around. Alternatively I can choose not fail on delete operations for the AWS infrastructure components but I don't want to leave a bunch of orphaned resources. Do you know if there is a job to cleanup Amazon resources periodically?

@sedefsavas
Copy link
Contributor

@josh-ferrell
We are using https://github.com/kubernetes-sigs/boskos/tree/master/aws-janitor/resources and I see IGW cleanup already exists.
It would be good to understand what is going on here by logging the error message instead of relying on Boskos.

@sedefsavas sedefsavas added this to the v1.4.0 milestone Mar 1, 2022
@sedefsavas sedefsavas added area/testing Issues or PRs related to testing and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 1, 2022
@josh-ferrell
Copy link
Author

/test pull-cluster-api-provider-aws-e2e

2 similar comments
@sedefsavas
Copy link
Contributor

/test pull-cluster-api-provider-aws-e2e

@josh-ferrell
Copy link
Author

/test pull-cluster-api-provider-aws-e2e

@josh-ferrell
Copy link
Author

josh-ferrell commented Mar 1, 2022 •
edited

@sedefsavas @pydctw This looks to be passing now if it looks good to you

@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@k8s-ci-robot
Copy link
Contributor

@josh-ferrell: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sedefsavas
Copy link
Contributor

LGTM after commits are squashed.

@sedefsavas
Functioning Sec Groups E2E test and refactor AWS infrastructure funct…
29cdc1d 
…ions

Add additional filter to getSubnetID function based on clusterName

Apply suggestions from code review

Co-authored-by: sedefsavas <58447606+sedefsavas@users.noreply.github.com>
@sedefsavas
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit b2bc437 into kubernetes-sigs:main Mar 2, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.4.0, v1.x Mar 2, 2022
@josh-ferrell josh-ferrell deleted the e2e_managed_secgrp branch March 29, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedefsavas sedefsavas sedefsavas left review comments

@pydctw pydctw Awaiting requested review from pydctw

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josh-ferrell @k8s-ci-robot @Ankitasw @pydctw @sedefsavas