fix: asgNeedsUpdates invalid condition (pointers)

[mweibel]

What type of PR is this?
/kind bug

What this PR does / why we need it:
machinePoolScope.MachinePool.Spec.Replicas and existingASG.DesiredCapacity are both pointers.
The previous condition compared memory addresses instead of integer values.

Special notes for your reviewer:
I'm not sure if the check for existingASG.DesiredCapacity == nil is needed (i.e. can it happen at all?) but I played a bit on the safe side here. The check could still fail overall if machinePoolScope.MachinePool.Spec.Replicas is nil, but I guess that should never happen. Or does it?

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

fixes logic for determining if an AutoScalingGroup needs updates

[k8s-ci-robot]

@mweibel: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @mweibel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pydctw]

/ok-to-test

[pydctw]

I'm not sure if the check for existingASG.DesiredCapacity == nil is needed (i.e. can it happen at all?) but I played a bit on the safe side here. The check could still fail overall if machinePoolScope.MachinePool.Spec.Replicas is nil, but I guess that should never happen. Or does it?

As existingASG.DesiredCapacity is a pointer, it can be nil. Same for MachinePool replicas spec. When a field is defined as a pointer, it is usually to distinguish between explicit zero and not specified.

Whether that is a real use case is a different story but we will need to check those conditions.

[pydctw]

FYI, MachinePool spec replicas is defaulted to 1 if nil.
https://github.com/kubernetes-sigs/cluster-api/blob/main/exp/api/v1beta1/machinepool_webhook.go#L51-L53

[mweibel]

As existingASG.DesiredCapacity is a pointer, it can be nil. Same for MachinePool replicas spec. When a field is defined as a pointer, it is usually to distinguish between explicit zero and not specified.

Whether that is a real use case is a different story but we will need to check those conditions.

Makes sense.

I added another condition to ensure it does return true when Replicas is nil, even though the Webhook should take care of this part. Hope that's fine, otherwise please let me know :)

[mweibel]

restarting the timed out test (not sure if I can do that)

/test pull-cluster-api-provider-aws-verify

[shivi28]

/test pull-cluster-api-provider-aws-test

[pydctw]

Thanks for adding missing tests in addition to what you are fixing in the PR.

/lgtm

[mweibel]

/assign @enxebre

[Ankitasw]

/unassign @enxebre
/assign @richardcase
for approval

[richardcase]

/test ?

[k8s-ci-robot]

@richardcase: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-aws-build
• /test pull-cluster-api-provider-aws-test
• /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-aws-apidiff-main
• /test pull-cluster-api-provider-aws-e2e
• /test pull-cluster-api-provider-aws-e2e-blocking
• /test pull-cluster-api-provider-aws-e2e-conformance
• /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-aws-apidiff-main
• pull-cluster-api-provider-aws-build
• pull-cluster-api-provider-aws-test
• pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e

[mweibel]

tests ran through 👍 thanks for retesting.

[richardcase]

Both sets of e2e are passing so:

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment