New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Developer guideline to write unit/integration tests in CAPA repo #3289
Conversation
@Ankitasw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve cc @pydctw if there is any comment. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8de2aa8
to
9984a9f
Compare
@sedefsavas @pydctw please let me know if you have any comments here. |
9984a9f
to
4adaf01
Compare
14e0310
to
f7ce935
Compare
+1 discussing naming conventions during office hours. |
f7ce935
to
8b5b4ab
Compare
8b5b4ab
to
5c5ed28
Compare
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
As part of #2910, we have added few integration and unit tests in controllers. We have separated two files *_unit_test.go specifically for unit tests and *_test.go for integration tests.
This PR makes clear distinction between the two files and convention of how to differentiate integration vs unit tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3288
Checklist:
Release note: