Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to use latest Kind version v0.12.0 #3293

Merged
merged 1 commit into from Mar 16, 2022
Merged

Upgrade to use latest Kind version v0.12.0 #3293

merged 1 commit into from Mar 16, 2022

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Mar 9, 2022 •
edited

What type of PR is this?
/area release

What this PR does / why we need it:
This updates to make use of latest kind v0.12.0 version

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Upgrade to use latest Kind version v0.12.0

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

@shivi28: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 9, 2022
@Ankitasw
Copy link
Member

Ankitasw commented Mar 9, 2022

/test pull-cluster-api-provider-aws-e2e

@shivi28
Copy link
Contributor Author

shivi28 commented Mar 9, 2022 •
edited

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

Ankitasw commented Mar 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@Ankitasw Ankitasw mentioned this pull request Mar 9, 2022
Closed
@pydctw
Copy link
Contributor

pydctw commented Mar 9, 2022

I don't see hack/ensure-kind.sh is used in our codebase.

Shouldn't it be referenced from ci scripts?

@shivi28
Copy link
Contributor Author

shivi28 commented Mar 12, 2022

Nice observation @pydctw. Thanks for bringing this.
Even the hack/ensure-kubectl.sh is not used anywhere.
I will make these changes and add it in above files as per your suggestion.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2022
@shivi28
Copy link
Contributor Author

shivi28 commented Mar 12, 2022

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e

@Ankitasw Ankitasw mentioned this pull request Mar 14, 2022
Closed
@Ankitasw
Copy link
Member

Hey @shivi28, thanks for the PR 🎉
It would also be great if we take care of updating the kind version in go.mod in hack/tools, wdyt?

@shivi28
Copy link
Contributor Author

shivi28 commented Mar 14, 2022 •
edited

Hey @shivi28, thanks for the PR 🎉 It would also be great if we take care of updating the kind version in go.mod in hack/tools, wdyt?

I think this could be handled by this PR. If there is no specific reason to close this PR then I think you can reopen it. Wdyt?

@Ankitasw
Copy link
Member

Ankitasw commented Mar 14, 2022 •
edited

IMO all the version bump related to same library/tool should go in same PR, that's why closed the other PR so that we can merge both together in one. For example, we closed this dependabot PR such that whole cluster api bump goes in one PR.
Wdyt?

@dlipovetsky
Copy link
Contributor

+1 to keeping related changes to the same PR. I'm not sure if we have permission to add commits to existing PRs in this repo; if we do, then adding commits to the dependabot PR #3305 is an option.

@Ankitasw
Copy link
Member

I'm not sure if we have permission to add commits to existing PRs in this repo; if we do, then adding commits to the dependabot PR #3305 is an option.

Atleast when I tried, I have no permission to do so. I think maintainers have that rights to amend to dependabot PR but I m not super sure.

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@pydctw
Copy link
Contributor

pydctw commented Mar 15, 2022

Nice observation @pydctw. Thanks for bringing this. Even the hack/ensure-kubectl.sh is not used anywhere. I will make these changes and add it in above files as per your suggestion.

Looks good to me. Thanks for also adding ensure-kubectl.sh to CI scripts.

@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit ceb478f into kubernetes-sigs:main Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@pydctw pydctw Awaiting requested review from pydctw

Assignees

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shivi28 @k8s-ci-robot @Ankitasw @pydctw @dlipovetsky @sedefsavas