Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] Test to check if bastion host is running when enabled #3318

Merged
merged 1 commit into from Mar 17, 2022
Merged

[E2E] Test to check if bastion host is running when enabled #3318

merged 1 commit into from Mar 17, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Mar 16, 2022 •
edited

What type of PR is this?
/area testing

What this PR does / why we need it:
Since we don't have any existing E2E tests to check if bastion host is up and running when enabled, this PR adds this check in existing multitenancy test(as it's faster as compared to other functional tests). This would also give assurity that bastion default AMI lookup is functioning properly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Follow up for #3298

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added E2E test to check if bastion host is running when enabled.

@Ankitasw Ankitasw changed the title [E2E] Test to check if bastion host is running when enabled [WIP] [E2E] Test to check if bastion host is running when enabled Mar 16, 2022
@Ankitasw Ankitasw changed the title [WIP] [E2E] Test to check if bastion host is running when enabled [WIP] Test to check if bastion host is running when enabled Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 16, 2022
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw Ankitasw changed the title [WIP] Test to check if bastion host is running when enabled [E2E] Test to check if bastion host is running when enabled Mar 16, 2022
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@Ankitasw
Copy link
Member Author

/retest

@sedefsavas
Copy link
Contributor

lgtm after tests pass.

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor

/test pull-cluster-api-provider-aws-test

@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2022
@Ankitasw
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 14af7f6 into kubernetes-sigs:main Mar 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Mar 17, 2022
@Ankitasw Ankitasw deleted the bastion-e2e-test branch March 17, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pydctw pydctw Awaiting requested review from pydctw

@richardcase richardcase Awaiting requested review from richardcase

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ankitasw @k8s-ci-robot @sedefsavas @richardcase