Makefile: don't log verbose from tests by default #3351
Conversation
|
@invidian: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
@invidian: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
Logs are useful for CI jobs, we can also add test-verbose like CAPI if we want this change. |
|
/test pull-cluster-api-provider-aws-test |
|
Aligned the PR more to what has been done in CAPI. |
|
/test pull-cluster-api-provider-aws-test |
|
@invidian please rebase your PR. |
|
@invidian let me know if you still face the issue of flaky test after rebasing. |
|
/approve Waiting for rebase for lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Test logs are mainly useful either when developing/debugging tests or when the tests are failing. If some test fails, Go will automatically print the outputs from this tests. Printing all test logs all the time makes it much difficult to find which test is actually failing and which output belongs to it, so I suggest we don't use -v by default. Similar change has been made in CAPI a while ago: kubernetes-sigs/cluster-api#4187 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@invidian can you add release note block, maybe copy from other PRs, as it's removed from template but the plugin to check the label in test-infra is yet to be merged. |
richardcase
removed
the
do-not-merge/release-note-label-needed
|
@Ankitasw I'm not sure what's the right format for the release notes now. And label doesn't want to disappear it seems. Do you mind editing the description yourself if you know what's the current format? |
|
@invidian looks like @richardcase took care :) |
|
Thanks for all! It's a small thing but a real quality improvement for development experience! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Test logs are mainly useful either when developing/debugging tests or
when the tests are failing. If some test fails, Go will automatically
print the outputs from this tests.
Printing all test logs all the time makes it much difficult to find
which test is actually failing and which output belongs to it, so I
suggest we don't use -v by default.
Similar change has been made in CAPI a while ago:
kubernetes-sigs/cluster-api#4187
Signed-off-by: Mateusz Gozdek mgozdek@microsoft.com
Release note: