-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: use 'rm -f' for verify-boilerplate #3442
Makefile: use 'rm -f' for verify-boilerplate #3442
Conversation
@invidian: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
So the target is idempotent and it does not print to stderr on CI. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Rebased to fix CI. |
New changes are detected. LGTM label has been removed. |
@invidian: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@invidian could you please run |
Verify failure is not related to this PR, merging. |
I did, but it didn't change anything :(
Thanks :) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
So the target is idempotent and it does not print to stderr on CI.
Example: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3344/pull-cluster-api-provider-aws-verify/1518490957455036416#1:build-log.txt%3A16