-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added owner-id
flag for clusterawsadm ami list
#3461
Added owner-id
flag for clusterawsadm ami list
#3461
Conversation
Signed-off-by: Abhinav Sinha <abhinav@nirmata.com>
@zeborg: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @zeborg. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Abhinav Sinha abhinav@nirmata.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently there’s no way to pass a custom owner ID for listing AMIs using
clusterawsadm ami list [...]
command, but there’s already an implementation for doing the same which is only limited by the lack of a flag to pass a custom owner ID instead of having to use the one owned by Heptio that’s hard-coded within the source atpkg/cloud/services/ec2/ami.go -> DefaultMachineAMIOwnerID
.This PR adds an additional
--owner-id
flag that can be used to list CAPA AMIs (following thecapa-ami-{{.BaseOS}}-{{.K8sVersion}}
naming format) on accounts other than the hard-coded one.cc - @sedefsavas
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: