-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed additionalTag application on unmanaged subnets #3512
Removed additionalTag application on unmanaged subnets #3512
Conversation
@Ankitasw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e3028cc
to
7f094b6
Compare
/test pull-cluster-api-provider-aws-e2e |
Also, adding a note to external infrastructure doc for this behaviour will be useful. I think there is already a section stating that we add CCM tags for unmanaged resources, but need to clarify additionalTags will not get propagated. |
7f094b6
to
d1ea4b4
Compare
d1ea4b4
to
ec9aeb8
Compare
f4ca6cb
to
f49727e
Compare
This PR is ready for review. |
cc @sedefsavas @richardcase for review. |
f49727e
to
7568ba2
Compare
7568ba2
to
5bca8f0
Compare
cc @richardcase @sedefsavas for review |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR removes the adding additional tags from subnets in case of using BYO VPC. This makes the tagging behavior consistent across all the network components(like routetables, natgateways etc.).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3494
Checklist: