Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed additionalTag application on unmanaged subnets #3512

Merged

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Jun 8, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR removes the adding additional tags from subnets in case of using BYO VPC. This makes the tagging behavior consistent across all the network components(like routetables, natgateways etc.).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3494

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2022
@Ankitasw Ankitasw changed the title Removed additionalTag application on unmamaged subnets Removed additionalTag application on unmanaged subnets Jun 8, 2022
@Ankitasw Ankitasw force-pushed the additional-tags-unmanaged-subnets branch from e3028cc to 7f094b6 Compare June 8, 2022 13:12
@Ankitasw
Copy link
Member Author

Ankitasw commented Jun 8, 2022

/test pull-cluster-api-provider-aws-e2e

@sedefsavas sedefsavas added this to the v1.5.0 milestone Jun 9, 2022
@sedefsavas
Copy link
Contributor

Also, adding a note to external infrastructure doc for this behaviour will be useful. I think there is already a section stating that we add CCM tags for unmanaged resources, but need to clarify additionalTags will not get propagated.

@Ankitasw Ankitasw force-pushed the additional-tags-unmanaged-subnets branch from 7f094b6 to d1ea4b4 Compare June 10, 2022 07:42
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2022
@Ankitasw Ankitasw force-pushed the additional-tags-unmanaged-subnets branch from d1ea4b4 to ec9aeb8 Compare June 10, 2022 13:54
@Ankitasw Ankitasw requested a review from sedefsavas June 10, 2022 13:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
@Ankitasw Ankitasw force-pushed the additional-tags-unmanaged-subnets branch 2 times, most recently from f4ca6cb to f49727e Compare June 10, 2022 14:12
@Ankitasw
Copy link
Member Author

This PR is ready for review.

@Ankitasw
Copy link
Member Author

cc @sedefsavas @richardcase for review.

@Ankitasw Ankitasw force-pushed the additional-tags-unmanaged-subnets branch from f49727e to 7568ba2 Compare June 15, 2022 06:54
@Ankitasw Ankitasw requested a review from sedefsavas June 15, 2022 07:05
@Ankitasw Ankitasw force-pushed the additional-tags-unmanaged-subnets branch from 7568ba2 to 5bca8f0 Compare June 15, 2022 07:06
@Ankitasw
Copy link
Member Author

cc @richardcase @sedefsavas for review

@sedefsavas
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit fde49ea into kubernetes-sigs:main Jun 23, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.5.0, v1.x Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional tags should not apply to unmanaged subnets
4 participants