-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EKS AWSManagedMachinePool example to spot instances doc #3523
Conversation
@pydctw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -34,4 +34,17 @@ spec: | |||
spotMarketOptions: | |||
maxPrice: 0.02 # Price in USD per hour (up to 5 decimal places) | |||
``` | |||
> **IMPORTANT NOTE**: The experimental feature `MachinePool` does not support using spot instances as of now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct, good to have a note or warning on this here if there is no other warning in the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good point. Slightly modified the note from MachinePool
to AWSMachinePool
as one variation of machine pool implementation, AWSManagedMachinePool, supports spot instance and moved to the end.
75b4be9
to
1ac7549
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add an example how to use spot instances with a EKS managed node group backed by AWSManagedMachinePool.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2523
Special notes for your reviewer:
Checklist: