Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apidiff target #3634

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

Prajyot-Parab
Copy link
Contributor

Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

  • Fix apidiff target

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2022
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@sedefsavas
Copy link
Contributor

@Prajyot-Parab
Copy link
Contributor Author

Prajyot-Parab commented Jul 29, 2022

API diff job works https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-aws#pr-apidiff-main&show-stale-tests=

Which OS are you using?

Darwin Prajyots-MacBook-Pro.local 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64
prajyotparab@Prajyots-MacBook-Pro cluster-api-provider-aws % make apidiff
bash: -c: line 1: syntax error: unexpected end of file
make: *** [apidiff] Error 2

@Prajyot-Parab
Copy link
Contributor Author

API diff job works https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-aws#pr-apidiff-main&show-stale-tests=
Which OS are you using?

Darwin Prajyots-MacBook-Pro.local 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64
prajyotparab@Prajyots-MacBook-Pro cluster-api-provider-aws % make apidiff
bash: -c: line 1: syntax error: unexpected end of file
make: *** [apidiff] Error 2

@sedefsavas also checked on a linux VM just now, changes working fine there as well.

@Skarlso
Copy link
Contributor

Skarlso commented Jul 30, 2022

Oh wow, nice catch. I wonder how the job works. That's definitely a syntax error.

@Prajyot-Parab
Copy link
Contributor Author

Oh wow, nice catch. I wonder how the job works. That's definitely a syntax error.

I guess because job is running only on linux platform so its working fine, I observed issue on my Mac (Darwin).

@Ankitasw
Copy link
Member

Ankitasw commented Aug 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@Ankitasw
Copy link
Member

Ankitasw commented Aug 1, 2022

cc @richardcase for final approval.

@Ankitasw
Copy link
Member

Ankitasw commented Aug 9, 2022

cc @sedefsavas

@sedefsavas
Copy link
Contributor

/approve

@sedefsavas sedefsavas added this to the v1.6.0 milestone Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@sedefsavas sedefsavas modified the milestones: v1.6.0, v1.5.0 Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit eba89c2 into kubernetes-sigs:main Aug 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.6.0 milestone Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants