Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] Add ASG Instance AZ SDK API to CAPA API conversion #3816

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #3743

/assign dlipovetsky

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
@dlipovetsky
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Nov 4, 2022

/retest

looks like a fluke. 🤔

@AverageMarcus
Copy link
Member

/retest

Not sure why it's failing on the GPU test :/

@Ankitasw
Copy link
Member

Ankitasw commented Nov 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Nov 7, 2022

yay, tests passed

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky, Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Skarlso,dlipovetsky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Skarlso
Copy link
Contributor

Skarlso commented Nov 7, 2022

/hold

no it's still running. :D

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@Ankitasw
Copy link
Member

Ankitasw commented Nov 7, 2022

OMG, it's flaking almost everytime.

@Skarlso
Copy link
Contributor

Skarlso commented Nov 7, 2022

OMG, it's flaking almost everytime.

Yeah, what the heck is going on with that thing? :O

@Ankitasw
Copy link
Member

Ankitasw commented Nov 7, 2022

I think i have to investigate this test locally.

@Ankitasw
Copy link
Member

Ankitasw commented Nov 7, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1f66f27 into kubernetes-sigs:release-1.5 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants