Apply #3871 "Update LoadBalancerReadyCondition on deletion" to release-1.5

[mnitchev]

The LoadBalancerReadyCondition is sometimes explicitly patched and other times it only updates the awsCluster object. Furthermore the condition won't be patched by the patch helper in the AWSClusterReconciler, because it's not in the patch.WithOwnedConditions list. This change puts the condition in the list and also updates the condition reason to Deleted when the LB is not found. Without setting the condition in that case, the reconciler will set condition to Deleting and it will never go back to Deleted.

Co-authored-by: Jose Armesto github@armesto.net

What type of PR is this?
/kind bug

What this PR does / why we need it:

This is #3871, but for the release-1.5. The original PR could not be backported due to conflicts.

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[k8s-ci-robot]

Hi @mnitchev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Skarlso]

/ok-to-test

[AverageMarcus]

cc @richardcase

#3871 couldn't be cherry picked due to changes in type imports (I think) conflicting. This PR adds the same logic to the 1.5 codebase.

[dlipovetsky]

The import grouping needs to be fixed: dlipovetsky@feb6e32

I also see the linter complain about a file that isn't touched by this PR: dlipovetsky@2830053

[AverageMarcus]

/retest

[Skarlso]

/lgtm /approve

[Skarlso]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Skarlso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[richardcase]

/milestone v1.5.3