Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use instance profiles of nodepools and machine deployments for mapping roles #4058

Merged
merged 5 commits into from
Feb 20, 2023
Merged

fix: use instance profiles of nodepools and machine deployments for mapping roles #4058

merged 5 commits into from
Feb 20, 2023

Conversation

faiq
Copy link
Contributor

@faiq faiq commented Feb 10, 2023 •
edited
Loading

chore: refactor getting roles to be inline with PR review

test: adds an integration test to test getting roles logic

Also backports the following commit to 1.5 e0fc4de#diff-6ff1d74b482f5f7e1c2727b17204096fe4bf243e8b7bbb0099b5701b7d3f77b1L53-L54

What type of PR is this?
/kind bug
backports #4011

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @faiq. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 10, 2023
@faiq faiq force-pushed the faiq/release-1.5/fetch-instance-profiles branch from f72d585 to 085add0 Compare February 10, 2023 01:02
faiq and others added 2 commits February 10, 2023 14:58
@faiq
fix: use instance profiles of nodepools and machine deployments for m…
6ab0ca9 
…apping roles

chore: refactor getting roles to be inline with PR review

test: adds an integration test to test getting roles logic
@richardcase @faiq
refactor: add capi crds to testenv
439ef88 
Changed the testenv creation so that it explicitly adds the CRDs from
CAPI. This has been copied for CAPZ :) By making this change it caused
some tests to fail as the `Machine` definitions weren't valid and so
these have been updated.

Signed-off-by: Richard Case <richard.case@outlook.com>
@faiq faiq force-pushed the faiq/release-1.5/fetch-instance-profiles branch from 085add0 to 439ef88 Compare February 10, 2023 20:00
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2023
@faiq faiq mentioned this pull request Feb 10, 2023
Merged
4 tasks
@dlipovetsky
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2023
@dlipovetsky
Copy link
Contributor

Linter complains: pkg/cloud/services/iamauth/reconcile.go:26: File is not gci-ed with --skip-generated -s standard,default,prefix(sigs.k8s.io/cluster-api) (gci)

@faiq
Copy link
Contributor Author

faiq commented Feb 13, 2023

/test ?

@k8s-ci-robot
Copy link
Contributor

@faiq: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-1-5
  • /test pull-cluster-api-provider-aws-test-release-1-5
  • /test pull-cluster-api-provider-aws-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-eks-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-1-5
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-release-1-5
  • pull-cluster-api-provider-aws-e2e-blocking-release-1-5
  • pull-cluster-api-provider-aws-test-release-1-5
  • pull-cluster-api-provider-aws-verify-release-1-5

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@faiq
Copy link
Contributor Author

faiq commented Feb 13, 2023

/test pull-cluster-api-provider-aws-e2e-eks-release-1-5

@faiq
Copy link
Contributor Author

faiq commented Feb 16, 2023

/test pull-cluster-api-provider-aws-e2e-eks-release-1-5

@faiq
Copy link
Contributor Author

faiq commented Feb 16, 2023

/test pull-cluster-api-provider-aws-e2e-eks-release-1-5

@dlipovetsky
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@Ankitasw
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2195327 into kubernetes-sigs:release-1.5 Feb 20, 2023
@richardcase
Copy link
Member

/milestone v1.5.3

@k8s-ci-robot k8s-ci-robot added this to the v1.5.3 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@Skarlso Skarlso Awaiting requested review from Skarlso

Assignees

@dlipovetsky dlipovetsky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@faiq @k8s-ci-robot @dlipovetsky @Ankitasw @richardcase