Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for gc related tests #4142

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Fixes for gc related tests #4142

merged 1 commit into from
Mar 29, 2023

Conversation

wyike
Copy link
Contributor

@wyike wyike commented Mar 14, 2023 •
edited
Loading

(cherry picked from commit 331fe73)

What type of PR is this?

What this PR does / why we need it:
Backport #3999 to release-1.5 as suggested in #3998 (comment).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3998

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fixes bugs in garbage collection e2e tests

@wyike
Fixes for gc related tests
a6cb908 
(cherry picked from commit 331fe73)
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @wyike. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2023
@Ankitasw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2023
@Ankitasw
Copy link
Member

@wyike please update release notes.

@Ankitasw
Copy link
Member

/milestone v1.5.3

@k8s-ci-robot k8s-ci-robot added this to the v1.5.3 milestone Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2023
@wyike
Copy link
Contributor Author

wyike commented Mar 14, 2023

/milestone v1.5.3

done

@wyike
Copy link
Contributor Author

wyike commented Mar 14, 2023

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc

@k8s-ci-robot
Copy link
Contributor

@wyike: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-1-5
  • /test pull-cluster-api-provider-aws-test-release-1-5
  • /test pull-cluster-api-provider-aws-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-eks-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-1-5
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-release-1-5
  • pull-cluster-api-provider-aws-e2e-blocking-release-1-5
  • pull-cluster-api-provider-aws-test-release-1-5
  • pull-cluster-api-provider-aws-verify-release-1-5

In response to this:

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks-gc-release-1-5

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-1-5
  • /test pull-cluster-api-provider-aws-test-release-1-5
  • /test pull-cluster-api-provider-aws-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-eks-release-1-5
  • /test pull-cluster-api-provider-aws-e2e-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-1-5
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-release-1-5
  • pull-cluster-api-provider-aws-e2e-blocking-release-1-5
  • pull-cluster-api-provider-aws-test-release-1-5
  • pull-cluster-api-provider-aws-verify-release-1-5

In response to this:

/test pull-cluster-api-provider-aws-e2e-eks-gc-release-1-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member

To enable this we would need to add prow jobs for release 1.5, I guess.
cc @richardcase

@wyike wyike mentioned this pull request Mar 22, 2023
Closed
9 tasks
@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit cdea612 into kubernetes-sigs:release-1.5 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso left review comments

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wyike @k8s-ci-robot @Ankitasw @richardcase @Skarlso