chore: Backport allow annotation on MachinePool to set externally managed to release-1.5

[tasdikrahman]

chore: Backport allow annotation on MachinePool to set externally managed to release-1.5 #3683

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3918

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

allow annotation on MachinePool to set externally managed 

[k8s-ci-robot]

Hi @tasdikrahman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ankitasw]

cc @richardcase @Skarlso

[Skarlso]

Yo @tasdikrahman. Can you please update the description and add release notes? Cheers.

[Ankitasw]

/ok-to-test

[tasdikrahman]

I ended up removing these two mock calls https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/release-1.6/pkg/cloud/services/interfaces.go#L64-L65 which are present on release1.6. the tests pass locally. Let me know if you would like to change something else folks. Sorry I missed out the release notes in the original PR description, thanks for adding it @Ankitasw

[tasdikrahman]

noticed that it's failing on the e2e test with this

[1]     Should create a workload cluster [It]
[1]     /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.1.5/e2e/quick_start.go:77
[1] 
[1]     Timed out after 1500.000s.
              
[1]     Expected
[1]         <bool>: false
[1]     to be true

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/4171/pull-cluster-api-provider-aws-e2e-blocking-release-1-5/1642836389806477312 from this build

was thinking if we should resubmit the e2e.

[Ankitasw]

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

[Ankitasw]

This should fix it.

[Ankitasw]

@tasdikrahman could you please rebase your PR?

[Ankitasw]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tasdikrahman]

Just putting the backtracking here for reference in case someone checks how the above PR fixes the e2e tests.

The conf file is passed here in the e2e test

and then picked up by the capa-controller-manager here in the deployment config for the same with the feature gate EventBridgeInstanceState, which then enables the AWSInstanceStateController here