Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused context imports #4547

Merged

Conversation

damdo
Copy link
Member

@damdo damdo commented Oct 5, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes #4546

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

fix: remove unused context imports

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2023
@Skarlso
Copy link
Contributor

Skarlso commented Oct 5, 2023

What the heck. How? :O

@damdo
Copy link
Member Author

damdo commented Oct 6, 2023

The failures don't seem to be related WDYT @richardcase

@richardcase
Copy link
Member

The failures don't seem to be related WDYT @richardcase

No, these are other issues that have slipped through previously without the proper checks being in place.

Might be worth fixing the linter issues for rand.Read in this, wdyt?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
@damdo
Copy link
Member Author

damdo commented Oct 6, 2023

The failures don't seem to be related WDYT @richardcase

No, these are other issues that have slipped through previously without the proper checks being in place.

Might be worth fixing the linter issues for rand.Read in this, wdyt?

Fix included

@damdo
Copy link
Member Author

damdo commented Oct 6, 2023

/retest

@richardcase
Copy link
Member

richardcase commented Oct 6, 2023

As the pull-cluster-api-provider-aws-e2e-blocking-release-2-2 failure is a result of another change and wasn't picked up previously due to lack of PR checks i think we can merge this and follow up on another PR the failing test. I have created #4550 to do the follow up and marked it critical.

/override pull-cluster-api-provider-aws-e2e-blocking-release-2-2
/approve

@k8s-ci-robot
Copy link
Contributor

@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-e2e-blocking-release-2-2

In response to this:

As the pull-cluster-api-provider-aws-e2e-blocking-release-2-2 is a result of another change and wasn't picked up previously due to lack of PR checks i think we can merge this and follow up on another PR the failing test. I have created #4550 to do the follow up and marked it critical.

/override pull-cluster-api-provider-aws-e2e-blocking-release-2-2
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@Skarlso
Copy link
Contributor

Skarlso commented Oct 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit b0a62c8 into kubernetes-sigs:release-2.2 Oct 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants