New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support ignition v3 and presigned URLs #4553
✨ Support ignition v3 and presigned URLs #4553
Conversation
/assign @nrb @JoelSpeed @richardcase |
b4ce100
to
46a5d21
Compare
This looks pretty reasonable to me. The only thing that gives me pause is the release note being one line; it could be taken to imply that the ignition and presigned URL support are coupled, but I don't believe they are. |
46a5d21
to
187e364
Compare
Manual testing was performed, and presigned URLs worked great 🎉 |
Changes look reasonable to me, I've already tested and manually verified the ignition v3 changes |
Can you please include some basic proof for statements like these? |
Also, some issues would be great so we could discuss them and their usefulness. |
Signed-off-by: Vince Prignano <vincepri@redhat.com>
187e364
to
a65f1f5
Compare
/lgtm Should be okay after rebase. |
/test pull-cluster-api-provider-aws-e2e |
/retest failure is not related |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for more versions of ignition, based on the work the @JoelSpeed started in https://github.com/openshift/cluster-api-provider-aws/pull/475/files.
It includes the ability for CAPA to generate presigned URLs and not rely on IAM roles.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4491
Special notes for your reviewer:
Checklist:
Release note: