Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eks e2e test failing as subnet name was used #4575

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix: eks e2e test failing as subnet name was used #4575

merged 3 commits into from
Oct 30, 2023

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Oct 12, 2023 •
edited
Loading

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4574

Special notes for your reviewer:

Checklist:

  • squashed commits

Release note:

Fix issue with EKE e2e tests due to a issue when specifying which subnets to use.

@richardcase
wip: eks e2e changes
42ad8a3 
Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2023
@richardcase
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks-testing

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase
wip: eks e2e changes
3f5eccb 
Signed-off-by: Richard Case <richard.case@outlook.com>
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks-testing
/test pull-cluster-api-provider-aws-e2e-eks-gc

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-testing
/test pull-cluster-api-provider-aws-e2e-eks-gc

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-test

@richardcase richardcase mentioned this pull request Oct 26, 2023
Closed
@richardcase
Copy link
Member Author

I'll get the failing tests fixed today

@richardcase richardcase mentioned this pull request Oct 26, 2023
Closed
4 tasks
@richardcase
chore: fix eks e2e
e53f691 
After the recenet change around the subnets the e2e where breaking as
it wasn't using the new resource id field.

Signed-off-by: Richard Case <richard.case@outlook.com>
@richardcase
Copy link
Member Author

Running the e2e again:

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-testing
/test pull-cluster-api-provider-aws-e2e-eks-gc

@richardcase richardcase changed the title [WIP] eks e2e changes fix: eks e2e test failing as subnet name was used Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 26, 2023
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-apidiff-main

@richardcase
Copy link
Member Author

Lets also check the non-EKS e2e:

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member Author

EKS and non-EKS tests passing

@cnmcavoy
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
AndiDog
AndiDog reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AndiDog
Copy link
Contributor

AndiDog commented Oct 30, 2023

/test pull-cluster-api-provider-aws-apidiff-main

@dlipovetsky
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9b5d146 into kubernetes-sigs:main Oct 30, 2023
21 of 22 checks passed
@AndiDog AndiDog mentioned this pull request Oct 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndiDog AndiDog AndiDog left review comments

@cnmcavoy cnmcavoy cnmcavoy approved these changes

@luthermonson luthermonson Awaiting requested review from luthermonson

@shivi28 shivi28 Awaiting requested review from shivi28

Assignees

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@cnmcavoy cnmcavoy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E2E] EKS tests are failing
5 participants
@richardcase @k8s-ci-robot @cnmcavoy @AndiDog @dlipovetsky