Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAPA supported AMI OS #4597

Merged
merged 1 commit into from Oct 30, 2023
Merged

Conversation

wyike
Copy link
Contributor

@wyike wyike commented Oct 28, 2023

What type of PR is this?
/kind support

What this PR does / why we need it:
Recent image-builder has removed support on ubuntu1804 in recent releases: here.
CAPA in the meanwhile follows the same, starts to support ubuntu2204 ami and drop support on ubuntu1804 ami. When listing amis with clusterawsadm, add ubuntu2204 filter to include ubuntu2204 to the list result.
In this PR, it also fixes a typo on a duplicate region ap-northeast-2 on the doc

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

build clusterawsadm and test locally:

clusterawsadm ami list --kubernetes-version=v1.28.2 --region=ap-southeast-2
KUBERNETES VERSION   REGION           OS               NAME                                         AMI ID
v1.28.2              ap-southeast-2   centos-7         capa-ami-centos-7-v1.28.2-1698240556         ami-04d09efb987ba6e39
v1.28.2              ap-southeast-2   ubuntu-22.04     capa-ami-ubuntu-22.04-v1.28.2-1698245433     ami-037833b5c08755eba
v1.28.2              ap-southeast-2   ubuntu-20.04     capa-ami-ubuntu-20.04-v1.28.2-1698246116     ami-0869d5134668ef6de
v1.28.2              ap-southeast-2   amazon-2         capa-ami-amazon-2-v1.28.2-1698240568         ami-00a9c865ebfb45d52
v1.28.2              ap-southeast-2   flatcar-stable   capa-ami-flatcar-stable-v1.28.2-1698242503   ami-04532cb90a1ddaa8a

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Update CAPA supported AMI OS: support on ubuntu2204 added, ubuntu1804 dropped

@k8s-ci-robot k8s-ci-robot added kind/support Categorizes issue or PR as a support question. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2023
@Ankitasw
Copy link
Member

Thanks for the PR @wyike

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit d2a44ce into kubernetes-sigs:main Oct 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants