Filter out reconciling events on externally managed AWSManagedClusters

[fiunchinho]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Users may specify that some AWS resources should not be managed by CAPA controllers, because they may be managed by a different mechanism. We expose the cluster.x-k8s.io/managed-by: "<name-of-system>" annotation, so that users can specify which resources should not be reconciled by capa controllers. We use it for our AWSCluster controller, but we don't use it for our AWSManagedCluster controller. I believe it should also use it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Filter out reconciling events on externally managed AWSManagedClusters

[fiunchinho]

/test ?

[k8s-ci-robot]

@fiunchinho: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-aws-build
• /test pull-cluster-api-provider-aws-test
• /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-aws-apidiff-main
• /test pull-cluster-api-provider-aws-e2e
• /test pull-cluster-api-provider-aws-e2e-blocking
• /test pull-cluster-api-provider-aws-e2e-clusterclass
• /test pull-cluster-api-provider-aws-e2e-conformance
• /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-aws-e2e-eks
• /test pull-cluster-api-provider-aws-e2e-eks-gc
• /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-aws-apidiff-main
• pull-cluster-api-provider-aws-build
• pull-cluster-api-provider-aws-test
• pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-testing

[fiunchinho]

/retest

[dlipovetsky]

Just for my own understanding, is this the use case?

I have an EKS control plane that I manage externally, but I want CAPA to manage the EKS worker machines.

[fiunchinho]

Just for my own understanding, is this the use case?

I have an EKS control plane that I manage externally, but I want CAPA to manage the EKS worker machines.

Yes I think so. CAPA won't reconcile that CR, but if you add MachineDeployments or MachinePools that don't contain the annotation, those will be reconciled normally by CAPA.

[dlipovetsky]

Since we already do this for unmanaged clusters, this seems reasonable.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlipovetsky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fiunchinho]

Can you take a look @faiq @cnmcavoy ? Thanks!

[cnmcavoy]

/lgtm