Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.2] 🐛 Fix deregistering of deleted CAPI Machines #4706

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[release-2.2] 🐛 Fix deregistering of deleted CAPI Machines #4706

merged 1 commit into from
Dec 20, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #4701

/assign tobiasgiese

Resolved issue where deleted control planes were still registered in the kube-apiserver load balancer, causing potential disruptions.

@tobiasgiese
Fix deregistering of deleted CAPI Machines
d6cd10b 
We have an issue that there is a gap between the CAPI Machine deletion and the AWSMachine deletion.
In this timeframe the kube-apiserver to the to be deleted control plane is no longer possible, but the deregistering of the LB member will be performed only for AWSMachine deletions.
This PR fixes the gap and also deregisteres the instance if the CAPI Machine is deleted.

Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 20, 2023
Merged
5 tasks
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2023
@tobiasgiese
Copy link
Member

/lgtm

PTAL @richardcase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4f46323 into kubernetes-sigs:release-2.2 Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@shivi28 shivi28 Awaiting requested review from shivi28

Assignees

@richardcase richardcase

@tobiasgiese tobiasgiese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @tobiasgiese @richardcase @k8s-ci-robot