🐛 ROSA: Fix domainPrefix not being set

[serngawy]

What type of PR is this?
/kind bug
In PR-4857 the domainPrefix has been mistakenly removed. setting it back

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

None

[k8s-ci-robot]

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[serngawy]

/cc @vincepri

[serngawy]

/cc @muraee

[muraee]

/retitle 🐛 ROSA: Fix domainPrefix not being set

[muraee]

/lgtm

[vincepri]

/ok-to-test
/retest

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• controlplane/rosa/OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/cherry-pick release-2.4

[k8s-infra-cherrypick-robot]

@damdo: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api-provider-aws#release-2.4 from head k8s-infra-cherrypick-robot:cherry-pick-4877-to-release-2.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-2.4 and k8s-infra-cherrypick-robot:cherry-pick-4877-to-release-2.4"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.