Cleanup services/userdata package #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
vincepri
force-pushed
the
userdata-tidy
branch
2 times, most recently
from
8e10045
to
4179459
Compare
chuckha
reviewed
Jul 9, 2019
| const ( | ||
| writeFilesTemplate = `write_files:{{ range . }} | ||
| - path: {{.Path}} | ||
| encoding: "base64" |
There was a problem hiding this comment.
Thanks for catching that!
| encoding: "base64" | ||
| owner: {{.Owner}} | ||
| permissions: '{{.Permissions}}' | ||
| content: | |
There was a problem hiding this comment.
This also appears to be a tab
There was a problem hiding this comment.
:D Seems like my editor loves tabs
|
|
||
| const ( | ||
| writeFilesTemplate = `write_files:{{ range . }} | ||
| - path: {{.Path}} |
There was a problem hiding this comment.
the spacing here looks funny, but it might still be valid YAML i honestly don't know
hello:
- path: item
There was a problem hiding this comment.
Should be the same as before in controlplane.go
vincepri
force-pushed
the
userdata-tidy
branch
2 times, most recently
from
d1e153c
to
ed17a3b
Compare
vincepri
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
the
lgtm
ncdc
pushed a commit
to ncdc/cluster-api-provider-aws
that referenced
this pull request
Jul 10, 2019
Signed-off-by: Vince Prignano <vincepri@vmware.com> (cherry picked from commit df5163d)
Merged
richardchen-db
pushed a commit
to databricks/cluster-api-provider-aws-1
that referenced
this pull request
Jan 14, 2023
Signed-off-by: Vince Prignano <vincepri@vmware.com> (cherry picked from commit df5163d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR cleans up the
userdatapackage and simplifies handling a large amount of files that need to be written to disk. In a future PR, this work is going to be used to store extra files on disk.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #847
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: