-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-duplicate and simplify code in the controllers unit tests #4404
Comments
This is also a follow-up from a discussion in #4208 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/kind cleanup
What needs cleanup:
Currently, the unit tests in the
controllers
package contains lots of duplicated code, mostly in the form of test objects. Many of these objects are re-defined in each test file with very little change in between them.For example, this test cluster object is re-defined 10 times in the controllers package.
Describe the solution you'd like
We should create a file that stores all of the common helper functions and objects that are used for unit tests in the
controllers
package.Files to change:
controllers
packageAnything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The text was updated successfully, but these errors were encountered: