Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses of field.NewPath should use camel case #4862

Closed
willie-yao opened this issue May 17, 2024 · 2 comments · Fixed by #4878
Closed

Uses of field.NewPath should use camel case #4862

willie-yao opened this issue May 17, 2024 · 2 comments · Fixed by #4878
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@willie-yao
Copy link
Contributor

/kind cleanup

What needs cleanup:
[A clear and concise description of what needs to be cleaned up.]

Uses of field.NewPath() should use camel case as pointed out here: #4792 (comment)

Incorrect use of field.NewPath(): https://github.com/willie-yao/cluster-api-provider-azure/blob/37702d1053c3c3802a1f8c40b0d8f98e56eb41ae/api/v1beta1/azuremachine_webhook.go#L184

Correct use of field.NewPath(): https://github.com/willie-yao/cluster-api-provider-azure/blob/add-mp-ci-ipv6/api/v1beta1/azuremachine_webhook.go#L210

Describe the solution you'd like
[Description of how you would like the cleanup to be done.]
Fix all uses of field.NewPath() that don't follow camel case.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 17, 2024
@lakshkeswani
Copy link
Contributor

@willie-yao could you please assign this to me? i can fix this issue

@nawazkh
Copy link
Member

nawazkh commented May 17, 2024

/assign @lakshkeswani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Status: Done
4 participants