Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored codebase to use camel case for spec parameter in field.NewPath method #4878

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

lakshkeswani
Copy link
Contributor

@lakshkeswani lakshkeswani commented May 24, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #4862

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits

Release note:

  NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2024
Copy link

linux-foundation-easycla bot commented May 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @lakshkeswani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR and working on this! Make sure to set the release note to "NONE" and sign the CNCF CLA. Also, whenever this PR is ready for review, please convert it from a draft PR to a normal PR!

Left a few comments on some nits and minor things that were missed.

api/v1beta1/azuremachinetemplate_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 7, 2024
@lakshkeswani lakshkeswani changed the title Refactored codbase to use field.NewPath should use camel case Refactored codbase to use camel case for spec parameter in field.NewPath method Jun 13, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 14, 2024
@lakshkeswani lakshkeswani changed the title Refactored codbase to use camel case for spec parameter in field.NewPath method Refactored codebase to use camel case for spec parameter in field.NewPath method Jun 14, 2024
@lakshkeswani lakshkeswani marked this pull request as ready for review June 14, 2024 06:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2024
@lakshkeswani
Copy link
Contributor Author

/ok-to-test

@willie-yao
Copy link
Contributor

/retest

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more changes! Also, don't forget to squash your commits once you've made all the changes.

api/v1beta1/azuremachine_validation.go Outdated Show resolved Hide resolved
api/v1beta1/azuremachinetemplate_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedmachinepooltemplate_webhook.go Outdated Show resolved Hide resolved
@lakshkeswani
Copy link
Contributor Author

@willie-yao I have resolved the comments have a look and i will squash the commits once i get go ahead from you.

@lakshkeswani
Copy link
Contributor Author

/retest

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @mboersma

Thanks for your work and patience on this! 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 696bbef3cdbb21c04bbec6c21a4096d453e1eb1a

@willie-yao
Copy link
Contributor

/hold for squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label tide/merge-method-squash
/hold cancel

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 28 lines in your changes missing coverage. Please review.

Project coverage is 62.18%. Comparing base (44aba04) to head (2f67a1d).
Report is 7 commits behind head on main.

Files Patch % Lines
api/v1beta1/azuremanagedcontrolplane_webhook.go 84.41% 12 Missing ⚠️
...v1beta1/azuremanagedmachinepooltemplate_webhook.go 62.96% 10 Missing ⚠️
...1beta1/azuremanagedcontrolplanetemplate_webhook.go 92.00% 2 Missing ⚠️
exp/api/v1beta1/azuremachinepool_webhook.go 33.33% 2 Missing ⚠️
api/v1beta1/azurecluster_webhook.go 88.88% 1 Missing ⚠️
api/v1beta1/azuremanagedmachinepool_webhook.go 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4878      +/-   ##
==========================================
- Coverage   62.19%   62.18%   -0.02%     
==========================================
  Files         201      201              
  Lines       16878    16878              
==========================================
- Hits        10497    10495       -2     
- Misses       5591     5593       +2     
  Partials      790      790              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit 90b76d3 into kubernetes-sigs:main Jun 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Uses of field.NewPath should use camel case
4 participants