Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for Storage Profile parameters #557

Closed
CecileRobertMichon opened this issue Apr 20, 2020 · 5 comments · Fixed by #658
Closed

Add validation for Storage Profile parameters #557

CecileRobertMichon opened this issue Apr 20, 2020 · 5 comments · Fixed by #658
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CecileRobertMichon
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
As part of the AzureMachine webhook, we should validate any spec passed in as part of OSDisk to make sure that it is valid and that it won't cause an error when creating the VM storage profile.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 20, 2020
@CecileRobertMichon CecileRobertMichon added this to Backlog in Cluster API Azure via automation Apr 20, 2020
@CecileRobertMichon
Copy link
Contributor Author

/help
/good-first-issue

Cluster API Azure automation moved this from Backlog to Done (2020 - Q1) Apr 20, 2020
Cluster API Azure automation moved this from Done (2020 - Q1) to In progress Apr 20, 2020
@CecileRobertMichon CecileRobertMichon moved this from In progress to Backlog in Cluster API Azure Apr 20, 2020
@CecileRobertMichon
Copy link
Contributor Author

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 20, 2020
@srm09
Copy link
Contributor

srm09 commented May 28, 2020

Working on this one.

@CecileRobertMichon
Copy link
Contributor Author

/assign @srm09

Cluster API Azure automation moved this from Backlog to Done (2020 - Q2) Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Cluster API Azure
  
Done (2020 - Q2)
Development

Successfully merging a pull request may close this issue.

3 participants