Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster and machine actuators tests #82

Closed
justaugustus opened this issue Jan 29, 2019 · 7 comments · Fixed by #145
Closed

Add cluster and machine actuators tests #82

justaugustus opened this issue Jan 29, 2019 · 7 comments · Fixed by #145
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@justaugustus
Copy link
Member

I did a bad thing in #68 and commented out the cluster and machine actuator tests, because the associated code had been fully refactored and the current code doesn't fit the old tests.

We've got to rewrite new tests ASAP.
/help
/priority critical-urgent
/cc @tariq1890 @soggiest

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

I did a bad thing in #68 and commented out the cluster and machine actuator tests, because the associated code had been fully refactored and the current code doesn't fit the old tests.

We've got to rewrite new tests ASAP.
/help
/priority critical-urgent
/cc @tariq1890 @soggiest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 29, 2019
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 29, 2019
@soggiest
Copy link
Contributor

/assign @soggiest

@soggiest
Copy link
Contributor

soggiest commented Feb 6, 2019

/milestone mvp

@k8s-ci-robot k8s-ci-robot added this to the mvp milestone Feb 6, 2019
@justaugustus
Copy link
Member Author

/milestone baseline

@justaugustus
Copy link
Member Author

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 6, 2019
@justaugustus
Copy link
Member Author

/remove-priority critical-urgent

@k8s-ci-robot k8s-ci-robot removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 6, 2019
@awesomenix
Copy link
Contributor

/assign @awesomenix

Already added cluster actuator test, working on machine actuator tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants